Skip to content

Conversation

@Mec-iS
Copy link
Collaborator

@Mec-iS Mec-iS commented Sep 27, 2025

  • Implement new distance cosine similarity
  • Implement a variant of fastpair that uses cosine similarity

Checklist

  • My branch is up-to-date with development branch.
  • Everything works and tested on latest stable Rust.
  • Coverage and Linting have been applied

Current behaviour

New expected behaviour

Change logs

  • cosine distance
  • fastpair with cosine distance CosinePair

@codecov
Copy link

codecov bot commented Sep 27, 2025

Codecov Report

❌ Patch coverage is 46.54088% with 85 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.72%. Comparing base (9fef05e) to head (a438f64).
⚠️ Report is 2 commits behind head on development.

Files with missing lines Patch % Lines
src/algorithm/neighbour/cosinepair.rs 47.61% 66 Missing ⚠️
src/metrics/distance/cosine.rs 37.50% 15 Missing ⚠️
src/tree/decision_tree_classifier.rs 50.00% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #327      +/-   ##
===============================================
+ Coverage        45.23%   45.72%   +0.49%     
===============================================
  Files               90       93       +3     
  Lines             7775     7960     +185     
===============================================
+ Hits              3517     3640     +123     
- Misses            4258     4320      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Mec-iS Mec-iS merged commit 09be468 into development Sep 27, 2025
13 checks passed
@Mec-iS Mec-iS deleted the cosine-sim branch September 27, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants