Skip to content

chore: fix clippy warnings from Rust release 1.69 #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 25, 2023
Merged

chore: fix clippy warnings from Rust release 1.69 #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b6ca79
chore: fix clippy warnings from Rust release 1.69
morenol Apr 24, 2023
099a7d5
chore: run `cargo fmt`
morenol Apr 24, 2023
683cc03
refactor: remove unused type parameter
morenol Apr 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/linalg/basic/matrix.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,9 +431,9 @@ impl<T: Number + RealNumber> SVDDecomposable<T> for DenseMatrix<T> {}
impl<'a, T: Debug + Display + Copy + Sized> Array<T, (usize, usize)> for DenseMatrixView<'a, T> {
fn get(&self, pos: (usize, usize)) -> &T {
if self.column_major {
&self.values[(pos.0 + pos.1 * self.stride)]
&self.values[pos.0 + pos.1 * self.stride]
} else {
&self.values[(pos.0 * self.stride + pos.1)]
&self.values[pos.0 * self.stride + pos.1]
}
}

Expand Down Expand Up @@ -495,9 +495,9 @@ impl<'a, T: Debug + Display + Copy + Sized> ArrayView1<T> for DenseMatrixView<'a
impl<'a, T: Debug + Display + Copy + Sized> Array<T, (usize, usize)> for DenseMatrixMutView<'a, T> {
fn get(&self, pos: (usize, usize)) -> &T {
if self.column_major {
&self.values[(pos.0 + pos.1 * self.stride)]
&self.values[pos.0 + pos.1 * self.stride]
} else {
&self.values[(pos.0 * self.stride + pos.1)]
&self.values[pos.0 * self.stride + pos.1]
}
}

Expand All @@ -519,9 +519,9 @@ impl<'a, T: Debug + Display + Copy + Sized> MutArray<T, (usize, usize)>
{
fn set(&mut self, pos: (usize, usize), x: T) {
if self.column_major {
self.values[(pos.0 + pos.1 * self.stride)] = x;
self.values[pos.0 + pos.1 * self.stride] = x;
} else {
self.values[(pos.0 * self.stride + pos.1)] = x;
self.values[pos.0 * self.stride + pos.1] = x;
}
}

Expand Down
8 changes: 2 additions & 6 deletions src/model_selection/kfold.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,7 @@ mod tests {
(vec![0, 1, 2, 3, 7, 8, 9], vec![4, 5, 6]),
(vec![0, 1, 2, 3, 4, 5, 6], vec![7, 8, 9]),
];
for ((train, test), (expected_train, expected_test)) in
k.split(&x).into_iter().zip(expected)
{
for ((train, test), (expected_train, expected_test)) in k.split(&x).zip(expected) {
assert_eq!(test, expected_test);
assert_eq!(train, expected_train);
}
Expand All @@ -307,9 +305,7 @@ mod tests {
(vec![0, 1, 2, 3, 7, 8, 9], vec![4, 5, 6]),
(vec![0, 1, 2, 3, 4, 5, 6], vec![7, 8, 9]),
];
for ((train, test), (expected_train, expected_test)) in
k.split(&x).into_iter().zip(expected)
{
for ((train, test), (expected_train, expected_test)) in k.split(&x).zip(expected) {
assert_eq!(test.len(), expected_test.len());
assert_eq!(train.len(), expected_train.len());
}
Expand Down
12 changes: 3 additions & 9 deletions src/readers/csv.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ where
Matrix: Array2<T>,
{
let csv_text = read_string_from_source(source)?;
let rows: Vec<Vec<T>> = extract_row_vectors_from_csv_text::<T, RowVector, Matrix>(
let rows: Vec<Vec<T>> = extract_row_vectors_from_csv_text(
&csv_text,
&definition,
detect_row_format(&csv_text, &definition)?,
Expand All @@ -103,12 +103,7 @@ where

/// Given a string containing the contents of a csv file, extract its value
/// into row-vectors.
fn extract_row_vectors_from_csv_text<
'a,
T: Number + RealNumber + std::str::FromStr,
RowVector: Array1<T>,
Matrix: Array2<T>,
>(
fn extract_row_vectors_from_csv_text<'a, T: Number + RealNumber + std::str::FromStr>(
csv_text: &'a str,
definition: &'a CSVDefinition<'_>,
row_format: CSVRowFormat<'_>,
Expand Down Expand Up @@ -305,12 +300,11 @@ mod tests {
}
mod extract_row_vectors_from_csv_text {
use super::super::{extract_row_vectors_from_csv_text, CSVDefinition, CSVRowFormat};
use crate::linalg::basic::matrix::DenseMatrix;

#[test]
fn read_default_csv() {
assert_eq!(
extract_row_vectors_from_csv_text::<f64, Vec<_>, DenseMatrix<_>>(
extract_row_vectors_from_csv_text::<f64>(
"column 1, column 2, column3\n1.0,2.0,3.0\n4.0,5.0,6.0",
&CSVDefinition::default(),
CSVRowFormat {
Expand Down