Lesson 7 - Hardhat - FundMe (1st unit test)- TypeError: fundMe.priceFeed is not a function

[SimSimButDifferent]

Hi there,

I have been trying to get FundMe.test.js working and I am failing at the first hurdle. This is the error message I am getting when running $ yarn hardhat test.

const { assert } = require("chai")
const { deployments, ethers, getNamedAccounts } = require("hardhat")

describe("FundMe", async function() {
    let fundMe
    let deployer
    let mockV3Aggregator
    beforeEach(async function() {
        // deploy FundMe contract using hardhat deploy
        // const accounts = await ethers.getSigners()
        // const accountZero = accounts[0]
        deployer = (await getNamedAccounts()).deployer
        await deployments.fixture(["all"])
        fundMe = await ethers.getContract("FundMe", deployer)
        mockV3Aggregator = await ethers.getContract(
            "MockV3Aggregator",
            deployer
        )
    })

    describe("constructor", async function() {
        it("Sets the aggregator addresses correctly", async function() {
            const response = await fundMe.priceFeed()
            assert.equal(response, mockV3Aggregator.address)
        })
    })
})

Let me know if you need me to do anything regarding this. Any help on this comes much appreciated thank you!

[othaime-en]

Hey @SimSimButDifferent please share your fundme.sol contract code.

[othaime-en]

The type in the returns was supposed to be AggregatorV3Interface not address And on line 25 of your test script you need to use priceFeed instead of s_priceFeed Please make that change.

[SimSimButDifferent]

Thank you so much, the test has passed!

[theirrationalone]

Read comment infront of priceFeed aggregatorV3Interface type! :)

// SPDX-License-Identifier: MIT
// 1 - Pragma
pragma solidity ^0.8.8;
// 2 - Imports
import "@chainlink/contracts/src/v0.8/interfaces/AggregatorV3Interface.sol";
import "./PriceConverter.sol";
// 3 - Errors
error FundMe__NotOwner();

// 4 - Interfaces, 5 - Libraries, 6 - Contracts

/** @title A contract for crowd funding
 *  @author Simeon Campbell
 *  @notice This contract is to learn sample funding contract from Patrick Collins.
 *  @dev This impliments price feeds as our library
 */

contract FundMe {
    // 1 - Type declerations
    using PriceConverter for uint256;

    // 2 - State Variables
    mapping(address => uint256) public addressToAmountFunded;
    address[] public funders;
    // Could we make this constant?  /* hint: no! We should make it immutable! */
    address public immutable i_owner;
    uint256 public constant MINIMUM_USD = 50 * 10**18;
    AggregatorV3Interface public immutable priceFeed;         /** make it public(public visibility will automatically make a function for it, in abi structure you can make a cross-check!), compile it again and boom, Although i made it immutable because in code there is only one modification in whole program */

    // 4 - Modifiers
    modifier onlyOwner() {
        // require(msg.sender == owner);
        if (msg.sender != i_owner) revert FundMe__NotOwner();
        _;
    }

    constructor(address priceFeed) {
        s_priceFeed = AggregatorV3Interface(priceFeed);
        i_owner = msg.sender;
    }

    receive() external payable {
        fund();
    }

    fallback() external payable {
        fund();
    }

    function fund() public payable {
        require(
            msg.value.getConversionRate(s_priceFeed) >= MINIMUM_USD,
            "You need to spend more ETH!"
        );
        // require(PriceConverter.getConversionRate(msg.value) >= MINIMUM_USD, "You need to spend more ETH!");
        addressToAmountFunded[msg.sender] += msg.value;
        funders.push(msg.sender);
    }

    function withdraw() public onlyOwner {
        for (
            uint256 funderIndex = 0;
            funderIndex < funders.length;
            funderIndex++
        ) {
            address funder = funders[funderIndex];
            addressToAmountFunded[funder] = 0;
        }
        funders = new address[](0);
        // payable(msg.sender).transfer(address(this).balance);
        (bool callSuccess, ) = payable(msg.sender).call{
            value: address(this).balance
        }("");
        require(callSuccess, "Call failed");
    }
}

[Nikzadkhan]

hello @othaime-en im getting still the error please help me
i share my code:
FundMe.test.js code:
const { deployments, ethers, getNamedAccounts } = require("hardhat");
const { assert } = require("chai");
const {
isCallTrace,
} = require("hardhat/internal/hardhat-network/stack-traces/message-trace");
const { any } = require("hardhat/internal/core/params/argumentTypes");
describe("FundMe", function () {
let FundMe;
let deployer;
let mockV3Aggregator;
beforeEach(function () {
deployer = getNamedAccounts().deployer;
deployments.fixture(["all"]);
FundMe = ethers.getContract("FundMe", deployer);
mockV3Aggregator = ethers.getContract("MockV3Aggregator", deployer);
});
describe("constructor", function () {
it("sets the aggretator addresses correctly", async function () {
const response = await FundMe.fun();
assert.equal(response, mockV3Aggregator.address);
});
});
});

FundMe.sol code:

// SPDX-License-Identifier: MIT
pragma solidity ^0.8.24;

// imports style:

import "@chainlink/contracts/src/v0.8/shared/interfaces/AggregatorV3Interface.sol";
import "./PriceConverter.sol";

//Error style
error FundMe__NotOwner();

// Interfaces Style

// Libraries style

//>>>>>>>>>>>>>>>>>> NatSpec Format<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
/**

• @title A contract for crowd funding
• @author khan
• @notice this contract is to demo a sample funding contract
• @dev this implements PriceFeed as our library
  */

// Contracts Style
contract FundMe {
// Type Declarations
using PriceConverter for uint256;
// State Varaibles!
mapping(address => uint256) public addressToAmountFunded;
address[] public funders;

// Could we make this constant?  /* hint: no! We should make it immutable! */
address public /* immutable */ i_owner;
uint256 public constant MINIMUM_USD = 50 * 10 ** 18;

AggregatorV3Interface public priceFeed;

   modifier onlyOwner {
    // require(msg.sender == owner);
    if (msg.sender != i_owner) revert FundMe__NotOwner();
    _;
}

// Function Order: <<<<<<<<<
//// Constractor
////receive
////fallback
////external
////punlic
////internal
////private
////view / pure 



constructor(address priceFeedAddress) {
    i_owner = msg.sender;
    priceFeed = AggregatorV3Interface(priceFeedAddress);
}

receive() external payable {
    fund();
}

fallback() external payable {
    fund();
}

function fund() public payable {
    require(msg.value.getConversionRate(priceFeed) >= MINIMUM_USD, "You need to spend more ETH!");
    // require(PriceConverter.getConversionRate(msg.value) >= MINIMUM_USD, "You need to spend more ETH!");
    addressToAmountFunded[msg.sender] += msg.value;
    funders.push(msg.sender);
}



function priceFeedFun() public view returns(AggregatorV3Interface){
    return priceFeed;
}


function withdraw() public onlyOwner {
    for (uint256 funderIndex=0; funderIndex < funders.length; funderIndex++){
        address funder = funders[funderIndex];
        addressToAmountFunded[funder] = 0;
    }
    funders = new address[](0);
    // // transfer
    // payable(msg.sender).transfer(address(this).balance);
    // // send
    // bool sendSuccess = payable(msg.sender).send(address(this).balance);
    // require(sendSuccess, "Send failed");
    // call
    (bool callSuccess, ) = payable(msg.sender).call{value: address(this).balance}("");
    require(callSuccess, "Call failed");
}

// Explainer from: https://solidity-by-example.org/fallback/
// Ether is sent to contract
//      is msg.data empty?
//          /   \ 
//         yes  no
//         /     \
//    receive()?  fallback() 
//     /   \ 
//   yes   no
//  /        \
//receive()  fallback()

}

// Concepts we didn't cover yet (will cover in later sections)
// 1. Enum
// 2. Events
// 3. Try / Catch
// 4. Function Selector
// 5. abi.encode / decode
// 6. Hash with keccak256
// 7. Yul / Assembly

[Nikzadkhan]

[alymurtazamemon]

@SimSimButDifferent You do not have priceFeed function in your fund me contract.

This variable is private;

AggregatorV3Interface private s_priceFeed;

so create a getter function for it with the same name in fund me contract that you are accessing in your tests.

function priceFeed() public view returns(address) {
  return s_priceFeed;
}

[SimSimButDifferent]

Thanks for getting back to me, now the new function seems to be in conflict with the constructor function, i fiddled around for a bit but still cant seem to get it to work properly.

[krakxn]

Is this resolved?

[SimSimButDifferent]

Yes indeed it is! cheers

[krakxn]

Good luck! :)