Skip to content

Conversation

@thisguy002
Copy link

fixes #8

@StephenFluin
Copy link
Contributor

StephenFluin commented Apr 29, 2021 via email

@thisguy002
Copy link
Author

I believe the policy should be that all images are self hosted going forward so the site has no external dependencies. We should have an 'images' or '_images'.

On Thu, Apr 29, 2021, 4:35 AM Alex Roan @.> wrote: @.* requested changes on this pull request. ------------------------------ In docs/Introduction/architecture-overview/architecture-decentralized-model.md <#50 (comment)> : > @@ -26,8 +26,8 @@ Each price feed is updated by multiple, independent Chainlink oracle operators. "images": [ { "image": [ - "https://files.readme.io/bf08b31-5ef7eba-screenshot.png", - "5ef7eba-screenshot.png", + "https://i.imgur.com/QaJm3i7.png", Do we have a policy for where we host images? Also, the caption on line 35 should be data.chain.link instead of feeds.chain.link. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#50 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABIJQDZBA5JQWWXVXE2M4DTLFABPANCNFSM43ZT74AA .

Ok. I'll create an image folder.

@thisguy002 thisguy002 force-pushed the dmitrydao/price-aggregation branch 2 times, most recently from c23fa8e to d563b85 Compare April 29, 2021 13:07
@thisguy002 thisguy002 requested a review from alexroan April 29, 2021 13:07
@thisguy002 thisguy002 force-pushed the dmitrydao/price-aggregation branch from d563b85 to 14bd212 Compare April 29, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update image for Price Aggregation

3 participants