remove pre spacing for tab bars #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexroan
suggested changes
Apr 28, 2021
Contributor
alexroan
left a comment
alexroan
left a comment
There was a problem hiding this comment.
Whilst we're here, do you think we could adjust the space below the tab-bar text to equal the space above? (or vice-versa?)
StephenFluin
force-pushed
the
stephen/fix-tab-bar-size
branch
from
64ab892 to
7d38f63
Compare
Contributor
Author
|
@alexroan Updated to be closer. Still not perfect due to rounding on top left corner of code, but I think this is close enough for now.
I also realized I had the css class defined twice, fixed. |
In a previous commit we added 24 pixels of space above and below every code example. This unintentionally added space between the tab bar and the code sample. This negative margin removes the extra space.
StephenFluin
force-pushed
the
stephen/fix-tab-bar-size
branch
from
7d38f63 to
9b559a1
Compare
alexroan
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous commit we added 24 pixels of space above and below every code
example. This unintentionally added space between the tab bar and the code
sample. This negative margin removes the extra space.