set max gas limit for check/simulate upkeeps #7423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
Contributor
Contributor
FelixFan1992
requested review from
connorwstein,
prashantkumar1982 and
spooktheducks
as code owners
FelixFan1992
requested review from
a team
and removed request for
connorwstein,
prashantkumar1982 and
spooktheducks
jmank88
reviewed
Sep 13, 2022
infiloop2
requested changes
Sep 14, 2022
Contributor
infiloop2
left a comment
infiloop2
left a comment
There was a problem hiding this comment.
We will also need to add a limit on performData size when we remove simulation gas limits
jmank88
reviewed
Sep 15, 2022
jmank88
reviewed
Sep 15, 2022
* add task to calculate string length * add task to calculate less than operation * add max performdata check in pipeline * fixes * small fix * format toml * another attempt at formatting * add integration test for max perform data size * add env var for max perform data size * small rename * fix unit test * add mocks and test data * fix tests * fix tests * generate docs Co-authored-by: FelixFan1992 <[email protected]>
infiloop2
reviewed
Sep 16, 2022
Comment on lines
20
to
23
| encode_check_upkeep_tx [type=ethabiencode | ||
| abi="checkUpkeep(uint256 id, address from)" | ||
| data="{\"id\":$(jobSpec.upkeepID),\"from\":$(jobSpec.fromAddress)}"] | ||
| check_upkeep_tx [type=ethcall |
pinebit
suggested changes
Sep 16, 2022
| TaskTypeETHABIDecode TaskType = "ethabidecode" | ||
| TaskTypeETHABIDecodeLog TaskType = "ethabidecodelog" | ||
| TaskTypeMerge TaskType = "merge" | ||
| TaskTypeLength TaskType = "length" |
Contributor
There was a problem hiding this comment.
You must:
- Describe these new tasks in our documentation here https://github.com/smartcontractkit/documentation and provide a link to the PR, so both are reviewed together.
- Mention the new tasks and other changes in CHANGELOG, so QA team knows what changes to test.
Contributor
There was a problem hiding this comment.
Done. documentation PR smartcontractkit/documentation#989
Contributor
There was a problem hiding this comment.
You added gasUnlimited param to eth_call task, that also need to be reflected in the doc.
Contributor
There was a problem hiding this comment.
pushed an update to the PR. There were some other parameters missing, i've also added documentation for them, could you verify that once
jmank88
reviewed
Sep 16, 2022
pinebit
approved these changes
Sep 16, 2022
cmalec
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new pipeline tasks: length and less than. Docs here add docs for length and less than task documentation#989
use unlimited gas in check/perform simulation. Add step in pipeline to limit perform data size