Add hexencode/base64encode tasks #7167
Conversation
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
| return Result{Error: errors.Wrap(err, "task inputs")}, runInfo | ||
| } | ||
|
|
||
| if strValue, ok := inputs[0].Value.(string); ok { |
There was a problem hiding this comment.
I think this approach is wrong, because it will not support expressions like $(other_task.result).
In other tasks you could find statements like this:
errors.Wrap(ResolveParam(&input, From(VarExpr(t.Input, vars), Input(inputs, 0))), "input"),
Here, VarExpr is handling the case of expressions. However, this requires to know the exact variable type.
At the same time we do not support types like "variant".
I would suggest to limit the supported types to:
- string
- []byte
- uint/int of arbitrary precision
Then you can do a chain of if-else for errors.Wrap(ResolveParam(&input, From(VarExpr(t.Input, vars), Input(inputs, 0))), "input"), trying to match the parameter type, and failing in the last else.
Would this work?
Other approach is to introduce a new param type, like VariantParam and then do what ETHABIEncodeTask2 does in convertToETHABIType function.
bolekk
force-pushed
the
feature/48275-create-hexencode-tasks
branch
2 times, most recently
from
3f8652b to
4fb776d
Compare
bolekk
requested review from
connorwstein,
prashantkumar1982 and
spooktheducks
as code owners
pinebit
left a comment
pinebit
left a comment
There was a problem hiding this comment.
LGTM, let's just iterate once on my comments. Thank you!
bolekk
force-pushed
the
feature/48275-create-hexencode-tasks
branch
from
4fb776d to
7cb286b
Compare
bolekk
force-pushed
the
feature/48275-create-hexencode-tasks
branch
from
7cb286b to
c18a94c
Compare
bolekk
force-pushed
the
feature/48275-create-hexencode-tasks
branch
from
c18a94c to
19d9f38
Compare
2 participants
Adding two new tasks: hexencode and base64encode
Docs in: smartcontractkit/documentation#909