Conversation
Contributor
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
Contributor
|
Does anybody know was there some specific reason we didn't upgrade geth before? |
5f316bc to
f6846c4
Compare
Contributor
|
IIRC there are some breaking API changes with geth in the last version. |
Bumps [github.com/ethereum/go-ethereum](https://github.com/ethereum/go-ethereum) from 1.9.12 to 1.9.15. - [Release notes](https://github.com/ethereum/go-ethereum/releases) - [Commits](ethereum/go-ethereum@v1.9.12...v1.9.15) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Contributor
|
One of the downsides of upgrading past our current version of go-ethereum is that it seems to add some noise at the begining of all of our test runs: |
Contributor
|
The breaking change appears to have come in this PR ethereum/go-ethereum#20895, where the function selector becomes an attribute instead of a method. |
f6846c4 to
199fed5
Compare
samsondav
approved these changes
Jun 12, 2020
still noisy. will somebody be updating olebedev/go-duktape.v3 to remove _duk_debugger_attach or is it a required function that is only referenced at run-time when the debugger attaches? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps github.com/ethereum/go-ethereum from 1.9.12 to 1.9.15.
Release notes
Sourced from github.com/ethereum/go-ethereum's releases.
Commits
0f77f34params: go-ethereum v1.9.15 stable6512334Merge pull request #21188 from karalabe/cht-1.9.15a5c827aparams: update CHTs for 1.9.15 release0b3f3beinternal/ethapi: return revert reason for eth_call (#21083)88125d8core: fix typo in comments (#21181)55f30dbcore/vm, crypt/bls12381: fixed comments in bls (#21182)9d93535node: missing comma on toml tags (#21187)4b2ff14go.mod: upgrade go-duktape to hide unused function warning (#21168)cefa2abMerge pull request #21173 from karalabe/faucet-delete-oldaccsb1b75f0accounts/keystore, cmd/faucet: return old account to allow unlockDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and language@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: