Fix bad geth log decoding#2476
Conversation
There was a problem hiding this comment.
In Solidity, the round ID field is roundId. Geth's Go code expects this to translate to RoundId, not RoundID, and fails to find the field if it doesn't.
There was a problem hiding this comment.
ethereum/go-ethereum#16648 <- does go-eth support these 'abi' tags?
i.e.
type MyEventParameters struct {
Value1 *big.Int `abi:"value"`
}
There was a problem hiding this comment.
Only on non-indexed fields. I plan to rework their decoding logic in a subsequent PR to add this feature for indexed fields.
There was a problem hiding this comment.
Ok as long as it was considered
There was a problem hiding this comment.
Can we pls have a comment explaining this. Not obvious.
|
Might be good to have a PR description and/or comment to help introduce context |
There was a problem hiding this comment.
Maybe keep as RoundID?
https://github.com/golang/go/wiki/CodeReviewComments#initialisms
There was a problem hiding this comment.
No, that was the whole issue in the first place -- Geth's code expected a lowercase final d
spooktheducks
dismissed
samsondav’s stale review
Changes made and this is urgent
spooktheducks
force-pushed
the
171761388-bug/fix-bad-geth-log-decoding
branch
from
cedcd85 to
c1a35b7
Compare
samsondav
left a comment
samsondav
left a comment
There was a problem hiding this comment.
LGTM just one tiny comment request
4 participants
No description provided.