update workflows and tool-versions #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tateexon
force-pushed
the
update_workflows_and_versions
branch
from
6fa33bb to
b362198
Compare
tateexon
force-pushed
the
update_workflows_and_versions
branch
from
b362198 to
71ebcaa
Compare
kalverra
approved these changes
Aug 29, 2022
Codecov Report
@@ Coverage Diff @@
## main #418 +/- ##
=======================================
Coverage 36.96% 36.96%
=======================================
Files 7 7
Lines 303 303
=======================================
Hits 112 112
Misses 182 182
Partials 9 9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
AnieeG
reviewed
Aug 29, 2022
.golangci.yaml
Outdated
Comment on lines
26
to
29
| - deadcode | ||
| - rowserrcheck | ||
| - structcheck | ||
| - varcheck |
There was a problem hiding this comment.
is it already being taken care by other checks and that's why disabled?
There was a problem hiding this comment.
They're deprecated. I don't think golangci runs them anymore though, so I think this is redundant?
There was a problem hiding this comment.
There was a problem hiding this comment.
I will see if removing them from the disabled list does indeed not run them.
There was a problem hiding this comment.
Removing works and pr is updated
AnieeG
reviewed
Aug 29, 2022
AnieeG
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings our .golangci file more up to date with the chainlink repo as well