Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed token account ordering and token indexes #1126

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

amit-momin
Copy link
Contributor

Issue

Accounts are expected to be provided in the following order for each token transfer. We expect ordering like below:

token receiver 1
token program 1
..accounts for 1
token receiver 2
token program 2
...accounts for 2

but ChainWriter configs are only able to order them like the following:

token receiver 1
token receiver 2
token program 1
token program 2
...

Solution

To be able to order the accounts properly, the logic to append these accounts to the transaction was added to the CCIP execute args transform. This also enables us to properly track the TokenIndexes required by our contracts.

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants