Fix SVR forwarder #236
Merged
Fix SVR forwarder #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 dimriou, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
cl-efornaciari
previously approved these changes
Sep 15, 2025
Comment on lines
350
to
355
| r, err := json.MarshalIndent(response.Result, "", " ") | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| a.lggr.Info("Response: ", string(r)) | ||
|
|
There was a problem hiding this comment.
can we add some tests to ensure the serialization works as expected
dimriou
force-pushed
the
svr_forwarder_fix
branch
from
5ff22c8 to
48a6873
Compare
cl-efornaciari
approved these changes
Sep 15, 2025
silaslenihan
approved these changes
Sep 15, 2025
dimriou
added a commit
that referenced
this pull request
Sep 16, 2025
* Fix SVR forwarder * Add more logs * Safeguard logs * Add omitempty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.