Use forge fmt over prettier #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since eslint-config-prettier only turns off rules and removing it doesn't trigger issues, it was not doing anything for us
RensR
commented
Aug 30, 2025
| - 'contracts/src/v0.8/vrf/**/*.sol' | ||
| shared: | ||
| - 'contracts/src/v0.8/shared/**/*.sol' | ||
| - 'contracts/src/v0.8/*.sol' |
Collaborator
Author
There was a problem hiding this comment.
Too wide, this would mean every single Solidity change triggers the shared CI.
RensR
commented
Aug 30, 2025
| @@ -1,87 +0,0 @@ | |||
| # This workflow is not active and will be removed on July 1st, 2025 | |||
RensR
commented
Aug 30, 2025
|
|
||
| import fs from 'fs' | ||
| import { exec } from 'child_process' | ||
| import { createHash } from 'crypto' |
Collaborator
Author
There was a problem hiding this comment.
Fixes the new HH paths and removes the dependency on ethers
Contributor
There was a problem hiding this comment.
RensR
commented
Aug 30, 2025
| "_comment2_logger": "See https://github.com/ethers-io/ethers.js/issues/379 we pin this version since that's what was used in the old yarn lockfile", | ||
| "overrides": { | ||
| "@ethersproject/logger": "5.0.6", | ||
| "@ethersproject/[email protected]>ws": "7.5.10", |
Collaborator
Author
There was a problem hiding this comment.
Remove old overrides that are no longer needed
RensR
commented
Aug 30, 2025
| "solhint": "^5.2.0", | ||
| "solhint-plugin-chainlink-solidity": "github:smartcontractkit/chainlink-solhint-rules#v1.2.1", | ||
| "solhint-plugin-prettier": "^0.1.0", | ||
| "ts-node": "^10.9.2", |
Collaborator
Author
There was a problem hiding this comment.
Replace ts-node with tsx to fix the Automation scripts
Contributor
product-security-plaid-test
bot
requested review from
Tofel,
anirudhwarrier,
dhaidashenko,
elatoskinas,
jadepark-dev,
kalverra,
karen-stepanyan,
mjk90 and
patrickhuie19
and removed request for
kalverra
pavel-raykov
approved these changes
Sep 1, 2025
RayXpub
approved these changes
Sep 1, 2025
alecgard
approved these changes
Sep 3, 2025
ibrajer
approved these changes
Sep 3, 2025
Fletch153
approved these changes
Sep 3, 2025
archseer
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reformats all Solidity code with forge fmt. It also cleans up some of the leftover NPM related imports and issues from #209
!!! The only bytecode changes is to an Automation interface that was generated by abi-to-sol that was out of date. One function is payable now. No other bytecode has changed.