Refactor dual broadcast clients #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed by accident |
dimriou
force-pushed
the
oev-393_metaclient
branch
from
af3b955 to
1f7ad31
Compare
jmank88
reviewed
Jun 19, 2025
| func SelectClient(lggr logger.Logger, client client.Client, keyStore keys.ChainStore, url *url.URL, chainID *big.Int) txm.Client { | ||
| urlString := url.String() | ||
| switch { | ||
| case strings.Contains(urlString, "flashbots"): |
There was a problem hiding this comment.
Is is possible to make this more specific to avoid incidental false positives? Like by comparing to the url fields, or including more characters at the start & end?
jmank88
reviewed
Jun 19, 2025
| SignTx(ctx context.Context, fromAddress common.Address, tx *evmtypes.Transaction) (*evmtypes.Transaction, error) | ||
| } | ||
|
|
||
| type MetaClient struct { |
There was a problem hiding this comment.
What does Meta mean in this context? We are already in package dualbroadcast, can this just be a dualbroadcast.Client?
There was a problem hiding this comment.
Er, maybe just some docs would help
cll-gg
reviewed
Jun 23, 2025
cll-gg
reviewed
Jun 23, 2025
| lggr logger.SugaredLogger | ||
| c client.Client | ||
| ks MetaClientKeystore | ||
| customURL *url.URL |
There was a problem hiding this comment.
Suggested change
| customURL *url.URL | |
| url *url.URL |
or
Suggested change
| customURL *url.URL | |
| endpoint *url.URL |
cll-gg
reviewed
Jun 23, 2025
cll-gg
reviewed
Jun 23, 2025
| Signature hexutil.Bytes `json:"signature"` | ||
| } | ||
|
|
||
| type requestResponse struct { |
There was a problem hiding this comment.
Slightly more descriptive:
Suggested change
| type requestResponse struct { | |
| type metaResponse struct { |
|
Please fill in the PR description a bit, helpful for traceability |
|
This PR is stale because it has been open 30 days with no activity. |
dimriou
force-pushed
the
oev-393_metaclient
branch
from
20db9bf to
0920cd0
Compare
dimriou
force-pushed
the
oev-393_metaclient
branch
from
2bc3717 to
6479762
Compare
dimriou
force-pushed
the
oev-393_metaclient
branch
from
4516176 to
5fb674c
Compare
silaslenihan
previously approved these changes
Sep 8, 2025
amit-momin
previously approved these changes
Sep 8, 2025
Farber98
previously approved these changes
Sep 8, 2025
ilija42
previously approved these changes
Sep 8, 2025
dimriou
dismissed stale reviews from ilija42, Farber98, amit-momin, and silaslenihan
via
360144c
dimriou
force-pushed
the
oev-393_metaclient
branch
from
bfdacb3 to
eea7b24
Compare
dimriou
force-pushed
the
oev-393_metaclient
branch
from
9ebf5a4 to
d12bb4d
Compare
DylanTinianov
approved these changes
Sep 9, 2025
silaslenihan
approved these changes
Sep 9, 2025
dimriou
added a commit
that referenced
this pull request
Sep 9, 2025
* Refactor dual broadcast clients * Fix DetectionURL * Add verification * More changes * Update metaclient params * Add control check * Add metacalldata unpacking for verification * Nit * Add tests * Update client * Fix send transaction bug * Add fuzzing tests * Don't broadcast without SOPs * Use mapstructure for unpacking input tuple to go struct * Tidy --------- Co-authored-by: Eric Fornaciari <[email protected]>
dimriou
added a commit
that referenced
this pull request
Sep 11, 2025
* Refactor dual broadcast clients * Fix DetectionURL * Add verification * More changes * Update metaclient params * Add control check * Add metacalldata unpacking for verification * Nit * Add tests * Update client * Fix send transaction bug * Add fuzzing tests * Don't broadcast without SOPs * Use mapstructure for unpacking input tuple to go struct * Tidy --------- Co-authored-by: Eric Fornaciari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.