Skip to content

Conversation

@patrickhuie19
Copy link
Contributor

@patrickhuie19 patrickhuie19 commented Nov 16, 2023

Previously the lint artifact was in xml, so the step to find errors omits the file name when logging to the action. This means that devs still have to pull the artifact down locally to fix lint errors, which I think is exactly what the step was trying to prevent.

Example:
https://github.com/smartcontractkit/chainlink-relay/actions/runs/6896336069/job/18762232176?pr=248

I saw two paths forward:

  • Change the output encoding to json, which is easier to parse than xml
  • Write a more complex parser for the xml to include the file name with the error

I chose the first, with the caveat that golangci-lint allows multiple output encodings/files, which is necessary as sonar only allows for golangci-lint artifacts with the checkstyle format: https://docs.sonarsource.com/sonarqube/latest/analyzing-source-code/importing-external-issues/external-analyzer-reports/#list-of-properties

The main thing we have to make sure of here is that no integration with sonar is broken.
Verified with https://github.com/smartcontractkit/chainlink-relay/pull/246/checks?check_run_id=18763287499 on commit 3328779 of this PR, which has parity with the same lint errors on #248

@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity.
Remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 28, 2025
@github-actions
Copy link

github-actions bot commented Jul 8, 2025

This PR has been automatically closed because it has been stale for > 30 days.
If you wish to continue working on this PR, please reopen it and make any necessary changes.

@github-actions github-actions bot closed this Jul 8, 2025
@github-actions github-actions bot deleted the fix/lint-action branch July 8, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants