-
Notifications
You must be signed in to change notification settings - Fork 25
Fixing print of lint errors in golangci-lint action #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a247d9f to
565492b
Compare
03cb911 to
074beca
Compare
074beca to
62c16ce
Compare
62c16ce to
5882db7
Compare
5882db7 to
00495d2
Compare
b48b329 to
a371de9
Compare
patrickhuie19
commented
Nov 17, 2023
chudilka1
approved these changes
Nov 20, 2023
chainchad
approved these changes
Nov 20, 2023
|
This PR is stale because it has been open 30 days with no activity. |
|
This PR has been automatically closed because it has been stale for > 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the lint artifact was in xml, so the step to find errors omits the file name when logging to the action. This means that devs still have to pull the artifact down locally to fix lint errors, which I think is exactly what the step was trying to prevent.
Example:
https://github.com/smartcontractkit/chainlink-relay/actions/runs/6896336069/job/18762232176?pr=248
I saw two paths forward:
I chose the first, with the caveat that golangci-lint allows multiple output encodings/files, which is necessary as sonar only allows for golangci-lint artifacts with the
checkstyleformat: https://docs.sonarsource.com/sonarqube/latest/analyzing-source-code/importing-external-issues/external-analyzer-reports/#list-of-propertiesThe main thing we have to make sure of here is that no integration with sonar is broken.
Verified with https://github.com/smartcontractkit/chainlink-relay/pull/246/checks?check_run_id=18763287499 on commit 3328779 of this PR, which has parity with the same lint errors on #248