Optimism L2 - token [Hardhat - v2] by krebernisak · Pull Request #33 · smartcontractkit/LinkToken

krebernisak · 2021-04-27T10:52:43Z

Add OVM compilation target through Hardhat Optimism plugin
Support compilation of multiple Solidity versions (0.4, 0.6, 0.7...) and multiple targets (EVM, OVM,...)
Add @chainlink/optimism-utils a set of useful functions to interact with Optimism network
Add LinkTokenChild contract, an access-controlled mintable & burnable LinkToken, for use on sidechains and L2 networks
Include vendor contract sources as submodules (mitigate supply chain type of attacks)
Moved CI from Travis to GitHub Actions
Add CI integration tests running L1 & L2 networks
Add contract versioning
Add CHANGELOG information

- Update OZ lib to v3.4.0, polish contracts, fix tests - Turn off solc bytecodeHash metadata generation - Move continuous integration to GitHub - Add target (OVM) support to getContractFactroy fn - Add Optimism L2 network bootstrap to CI integration job - Strictly declare Versions and Targets - Integrating @chainlink/optimism-utils - Update env loading and docs - Use 1_000_000 optimizer runs for v0.7 - Add LinkTokenChild contract - Run on self-hosted CI runner - Add yargs lib to parse argv - Add contract size and gas reporters

krebernisak · 2021-04-27T18:51:35Z

@alex & @yos please check out the Hardhat/OVM integration here. It supports the compilation of multiple versions (v0.4, v0.6, ...) and multiple targets (EVM, OVM,...). We'd need this functionality in multiple Solidity projects, so an idea is to try to share a setup like this and include it everywhere. I'd appreciate your feedback.

@Steve & @kaleofduty the LinkTokenChild contract is a core part of the proposal that can enable us to move quickly to new networks, while still staying flexible and having an upgrade path when the full bridge is deployed. The proposal is documented here.

se3000 · 2021-04-28T03:01:20Z

  "dependencies": {
    "@chainlink/contracts": "^0.1.6",
-    "@openzeppelin/contracts": "^3.4.0"
+    "@chainlink/optimism-utils": "https://github.com/smartcontractkit/optimism-utils.git",


Can't all of these other than OZ be moved into dev dependencies?

"Needs to be" a proper dependency as this is now more than just a raw contracts package. It brings some useful functions for consumers like Gauntlet to use, for example, the getContractFactory fn to load the factory by name for a specific version & target.

Most of that code could be extracted in a separate lib, and then reused here, in Feeds Registry repo, in our core evm-contracts, etc.

The specific "@chainlink/optimism-utils" dependency is because of optimism.loadEnv fn which is currently repo specific and does not have much use externally.

I've cleaned this a little, but still left the @chainlink/optimism-utils as a dependency. It's less confusing to use it this way currently. I agree we can organize this better, and please share your suggestions, but I guess this is good enough for now.

I vote we try to see how all of this fits into our larger set of contract repos & tools. We can try to use it (share hardhat & optimism utils) in Gauntlet, Feed Registry, core contracts, and then restructure it to fit better depending on the outcome.

Remove export of JS helper functions is the commit that addresses this.
JS code is not exported anymore and will be manually c/p to Gauntlet.

se3000

Probably not for this PR, but I think we should vendor our Solidity dependencies for this repo like we do for the others.

krebernisak · 2021-05-07T17:43:27Z

To see an example usage of the LinkTokenChild contract, in the context of Optimism, please check out the Optimism L2 - bridge #34 PR.

P.S. The CI fails because of upstream Optimism monorepo issues, locally works perfectly. Investigating...

- By doing this we are trying to lower the probablity of supply chain type of attacks

se3000 · 2021-05-11T02:13:31Z

Again, wondering if we should use submodules instead of manually copying a hash. Seems error prone and non-standard as is.

- style changes to LinkTokenChild contract - additional useful documentationn

lawrencexia

👍 to unblock merge - with the understanding that this branch has previously been reviewed, audited, and deployed

krebernisak force-pushed the feature/oe-token branch 2 times, most recently from e4fb6db to e971321 Compare April 27, 2021 11:19

krebernisak mentioned this pull request Apr 27, 2021

Optimism L2 integration [Hardhat - v2] #29

Closed

10 tasks

krebernisak force-pushed the feature/oe-token branch 2 times, most recently from e9afcef to 9464717 Compare April 27, 2021 18:01

krebernisak changed the title ~~Optimism L2 integration [Hardhat - v2]~~ Optimism L2 integration - token [Hardhat - v2] Apr 27, 2021

krebernisak changed the title ~~Optimism L2 integration - token [Hardhat - v2]~~ Optimism L2 - token [Hardhat - v2] Apr 27, 2021

krebernisak force-pushed the feature/oe-token branch from 9464717 to 5d44e69 Compare April 27, 2021 18:41

krebernisak requested review from alexroan, kaleofduty, thodges-gh and yosriady April 27, 2021 18:42

se3000 reviewed Apr 28, 2021

View reviewed changes

krebernisak force-pushed the feature/oe-token branch from 6dfa2c8 to 604d6fe Compare April 28, 2021 11:51

Add more LinkTokenChild tests

557b4f2

krebernisak force-pushed the feature/oe-token branch from 604d6fe to 557b4f2 Compare April 28, 2021 12:19

krebernisak commented Apr 30, 2021

View reviewed changes

Comment thread contracts/v0.7/bridge/token/LinkTokenChild.sol

se3000 reviewed May 4, 2021

View reviewed changes

Comment thread contracts/v0.7/bridge/token/LinkTokenChild.sol Outdated

Comment thread contracts/v0.7/bridge/token/LinkTokenChild.sol

Comment thread contracts/v0.7/bridge/token/LinkTokenChild.sol

krebernisak force-pushed the feature/oe-token branch from 5ce76ef to 8a5bfde Compare May 7, 2021 12:45

krebernisak added 2 commits May 8, 2021 07:42

Update with latest upstream changes

9b30fba

Introduce contract versioning

242a046

krebernisak force-pushed the feature/oe-token branch from 85e7a18 to 4051cd9 Compare May 9, 2021 20:47

se3000 reviewed May 10, 2021

View reviewed changes

Comment thread contracts/v0.6/mocks/Token677.sol Outdated

Comment thread contracts/vendor/@openzeppelin/contracts/3.4.1/commit.info Outdated

krebernisak added 4 commits May 10, 2021 10:36

Change v0.6 contracts code style

94f2aa3

Remove export of JS helper functions

a712092

- By doing this we are trying to lower the probablity of supply chain type of attacks

Include vendor contract source

9a0e59c

- By doing this we are trying to lower the probablity of supply chain type of attacks

Add CI network teardown step

27ecfda

se3000 reviewed May 11, 2021

View reviewed changes

Comment thread test/v0.7/bridge/token/LinkTokenChild.test.ts Outdated

se3000 reviewed May 11, 2021

View reviewed changes

Comment thread test/v0.7/bridge/token/LinkTokenChild.test.ts Outdated

krebernisak added 2 commits May 11, 2021 12:07

Polish tests

4413c43

Rename IERC20Child deposit/withdraw as mint/burn

bf2e2f7

krebernisak force-pushed the feature/oe-token branch from 24bf548 to b84c373 Compare May 11, 2021 20:29

se3000 approved these changes May 11, 2021

View reviewed changes

se3000 previously approved these changes May 12, 2021

View reviewed changes

krebernisak added 2 commits May 12, 2021 10:39

Use submodules for vendor contracts

0c557cc

Rename interfaces and flatten contracts

3b0ca75

krebernisak dismissed se3000’s stale review via 3b0ca75 May 12, 2021 09:38

krebernisak force-pushed the feature/oe-token branch from b84c373 to 3b0ca75 Compare May 12, 2021 09:38

Fix the L2 gasPrice to 1 gwei

7c41212

K-Ho mentioned this pull request May 12, 2021

estimateGas reverts, but the transaction succeeds with a hardcoded gasLimit ethereum-optimism/optimism#664

Closed

Fix tests error handling (avoid TX_OVERRIDES_BUG)

e317c66

krebernisak changed the base branch from master to chores/add-flattened-solidity June 9, 2021 10:35

krebernisak changed the base branch from chores/add-flattened-solidity to master June 9, 2021 10:35

krebernisak force-pushed the feature/oe-token branch from 1665f62 to 6a1c917 Compare June 28, 2021 15:11

Revert token name change

6c37ec6

krebernisak force-pushed the feature/oe-token branch from 6be520c to 6c37ec6 Compare July 9, 2021 11:13

Update to latest deps + compiler config bug fix

9e0dcd8

krebernisak mentioned this pull request Jul 13, 2021

v0.6/LinkToken uses the 0.7.x compiler version instead of 0.6.x #45

Closed

krebernisak added 5 commits July 15, 2021 14:40

Add README docs (NOTICE) for LinkTokenChild contract

70fca4f

- style changes to LinkTokenChild contract - additional useful documentationn

Remove Optimism 1 gwei fixed price

07371f6

Update to latest upstream changes

426f174

Merge branch 'master' into feature/oe-token

f8a0f44

Revert to before merge updated deps

b641420

lawrencexia approved these changes Aug 25, 2021

View reviewed changes

krebernisak merged commit 7ab441d into master Aug 25, 2021

krebernisak deleted the feature/oe-token branch August 25, 2021 11:14

Conversation

krebernisak commented Apr 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

krebernisak commented Apr 27, 2021

Uh oh!

se3000 Apr 28, 2021

Choose a reason for hiding this comment

Uh oh!

krebernisak Apr 28, 2021

Choose a reason for hiding this comment

Uh oh!

krebernisak Apr 28, 2021

Choose a reason for hiding this comment

Uh oh!

krebernisak May 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

se3000 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

krebernisak commented May 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

se3000 commented May 11, 2021

Uh oh!

lawrencexia left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

krebernisak commented Apr 27, 2021 •

edited

Loading

krebernisak May 7, 2021 •

edited

Loading

krebernisak commented May 7, 2021 •

edited

Loading