Skip to content

Update Broadlink controller#456

Merged
vassilis-panos merged 1 commit into
smartHomeHub:rcfrom
felipediel:update-blk-ctrl
Sep 8, 2020
Merged

Update Broadlink controller#456
vassilis-panos merged 1 commit into
smartHomeHub:rcfrom
felipediel:update-blk-ctrl

Conversation

@felipediel
Copy link
Copy Markdown
Contributor

@felipediel felipediel commented Aug 21, 2020

Broadlink devices are now configured via config flow and broadlink.send is deprecated in favor of remote.send_command.
This update is necessary to keep things working after these changes.

@vassilis-panos
Copy link
Copy Markdown
Member

So the time has come. I tried to avoid this for months because of the breaking change.
Thanks for your contribution. Really appreciate it.

@aidbish
Copy link
Copy Markdown

aidbish commented Aug 28, 2020

Any idea when a RC will be available to test this out

@felipediel
Copy link
Copy Markdown
Contributor Author

It is already merged into the dev branch. It may take a while to be released, as the master branch is 511 commits behind dev and these updates will be merged gradually. This is the master branch of the Broadlink integration. You can look into it to check if the updates from dev are already merged.

@aidbish
Copy link
Copy Markdown

aidbish commented Aug 31, 2020

It is already merged into the dev branch. It may take a while to be released, as the master branch is 511 commits behind dev and these updates will be merged gradually. This is the master branch of the Broadlink integration. You can look into it to check if the updates from dev are already merged.

but the smartir component needs to be updated to use it

@felipediel
Copy link
Copy Markdown
Contributor Author

You can pull this update from my fork. But you have to wait for the configuration flow update to be released in Home Assistant, or you can pull it from the dev branch to be the first to test.

@antlarr
Copy link
Copy Markdown

antlarr commented Sep 4, 2020

Hi, just to mention that I tried this PR together with home-assistant/core@a2c1f08 applied to home-assistant 0.114.4 and
mjg59/python-broadlink#407, mjg59/python-broadlink#410 and mjg59/python-broadlink#412 applied to python-broadlink with a RM4 mini (0x62bc) and it works great (it didn't work before).

@felipediel
Copy link
Copy Markdown
Contributor Author

Thanks for you hard work testing this update. I'm happy to know that it works for the RM4 series.

@vassilis-panos vassilis-panos changed the base branch from master to rc September 8, 2020 08:47
@vassilis-panos vassilis-panos merged commit 2bcf728 into smartHomeHub:rc Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants