Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependency versions #2

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

janlazo
Copy link

@janlazo janlazo commented May 25, 2019

Fix vulnerabilities from yarn audit and adjust rollup config to build the example for react and preact.

@janlazo janlazo changed the title Bump dependency versions [WIP] Bump dependency versions May 28, 2019
@janlazo
Copy link
Author

janlazo commented May 28, 2019

Leaving it WIP for now to upgrade smart-table-core, react, preact to the latest or maintained versions, similar to what I did for smart-table-vue.

search directive does not work in the example for react after the update. filter works.

onInput seems to be deprecated on react 16 so I used onChange react only.

@janlazo janlazo changed the title [WIP] Bump dependency versions Bump dependency versions Jun 19, 2019
@janlazo
Copy link
Author

janlazo commented Jun 19, 2019

I give up 😞 . I don't know enough about React to debug the problem with the search directive.

@lorenzofox3
Copy link
Contributor

don't worry and thank you for you help, I'll update it myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants