add SigningTimeNotValidError error #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessepeterson
changed the title
jessepeterson
commented
May 1, 2024
Comment on lines
+61
to
+62
| NotBefore time.Time // NotBefore of signer | ||
| NotAfter time.Time // NotAfter of signer |
There was a problem hiding this comment.
I'm not sure it makes sense to include these because the caller of p7.Verify() will also have access to the signer cert which can directly access the NotBefore/NotAfter. On the other hand it's nice and explicit to have the actual checked values right here in the error, too.
hslatman
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name of feature:
Add a specific typed error for an invalid signing time attribute invalid error.
Pain or issue this feature alleviates:
See discussion in #21.
Why is this important to the project (if not answered above):
Allows the capability specific handling of a signing time attribute by the caller of
.Verify()via e.g.errors.Is(). This would expose the specific signing time time.Time object along with the NotAfter and NotBefore of the signer.Is there documentation on how to use this feature? If so, where?
As an exported symbol the Go documentation should auto-generate once a release is cut.
In what environments or workflows is this feature supported?
Anybody using the P7 library.
In what environments or workflows is this feature explicitly NOT supported (if any)?
I suppose this error is never called if there's no signing time attribute (or it is valid).
Supporting links/other PRs/issues:
Again, see #21.
💔Thank you!