Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logic bug in WriteStreamSubscriberImpl skipping onNext when NOT done. #158

Closed
syndic8-stephen opened this issue Jul 13, 2020 · 2 comments
Closed

Logic bug in WriteStreamSubscriberImpl skipping onNext when NOT done. #158

syndic8-stephen opened this issue Jul 13, 2020 · 2 comments
Milestone
1.1.0

Comments

@syndic8-stephen
Copy link
Contributor

In trying to use WriteStreamSubscriber I found my items were not being delivered. On debug they were being skipped in onNext with "if (!done.get()) return" It seems this is the wrong way around and we want to skip and return immediately if done is true. I will add a pull request.
syndic8-stephen added a commit to syndic8-stephen/smallrye-reactive-utils that referenced this issue Jul 13, 2020
@syndic8-stephen
Logic bug in WriteStreamSubscriberImpl skipping onNext when NOT done. s…
b0d7f55 
…mallrye#158
cescoffier added a commit that referenced this issue Jul 14, 2020
@cescoffier
Merge pull request #159 from syndic8-stephen/master
ac9f8ec 
Logic bug in WriteStreamSubscriberImpl #158
@jponge
Copy link
Member

jponge commented Jul 15, 2020

Fixed by #159

@jponge
Copy link
Member

jponge commented Jul 15, 2020

@cescoffier you can close it :-) (I don't have permissions)

@cescoffier cescoffier added this to the 1.1.0 milestone Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
3 participants
@jponge @cescoffier @syndic8-stephen