[3.0] fix parameters handling #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These 2 changes in JDK 18 and JDK 21 require significant changes to how synthetic/mandated parameters and parameters names are handled: - https://bugs.openjdk.org/browse/JDK-8271623 - https://bugs.openjdk.org/browse/JDK-8292275 Therefore, with this commit, the `Indexer` no longer stores just method parameter name arrays. Instead, for each `MethodInfo` from currently processed class, it stores a `MethodParamList`, which contains 2 lists of `ParamData`, one based on the `MethodParameters` bytecode attribute and the other based on the local variable table. Those lists contain, for each method parameter, its name and synthetic/mandated flag. When the `Indexer` is done parsing a method, the `MethodParamList` is finished, which means computing: - whether the method is a constructor whose first parameter is the enclosing instance synthetic/mandated parameter; - list of parameters that are possibly named (synthetic/mandated parameters are ignored). This information is then used: - to compute the final array of parameter names (preferring the proper name over the debug name); - as part of a heuristic that figures out if a constructor belongs to an "inner" class (in case of local/anonymous classes, that in fact means figuring out if they were declared in non-static context).
Ladicek
force-pushed
the
fix-parameters-handling-3.0
branch
from
ad8c231
to
13260c8
Compare
They used to fail because of the ImpSort Maven plugin, which got inherited from the SmallRye Parent POM. This commit gets rid of the SmallRye Parent POM from the integration tests, because it's not necessary, and adds some minimal properties all Maven projects should have. The integration tests no longer run the ImpSort Maven plugin, which means they run with Maven 3.9 just fine.
Ladicek
force-pushed
the
fix-parameters-handling-3.0
branch
from
13260c8
to
ea78b87
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.