improve Index[View].getKnownUsers()
#354
Conversation
Ladicek
force-pushed
the
improve-known-users
branch
from
839b400
to
0553b9e
Compare
| return new Index(masterAnnotations, subclasses, subinterfaces, implementors, classes, modules, users); | ||
| Map<DotName, List<ClassInfo>> userLists = new HashMap<>(); | ||
| for (Map.Entry<DotName, Set<ClassInfo>> entry : users.entrySet()) { | ||
| userLists.put(entry.getKey(), new ArrayList<>(entry.getValue())); |
There was a problem hiding this comment.
I wonder if List#copyOf() could be a little bit more efficient here?
There was a problem hiding this comment.
Possibly, but Jandex is still on Java 8 :-)
There was a problem hiding this comment.
Ah, sorry. I forgot about it 🤦
|
I often add miniature features in micro releases, but you're probably right -- this should go into 3.2.0. I'll change the milestone and make this a draft for now. |
Ladicek
force-pushed
the
improve-known-users
branch
from
0553b9e
to
84e7350
Compare
There was a problem hiding this comment.
I suppose this is more general, and more useful than just appearing in the constant pool, although I suppose that in the first two use-cases we've had (calling static methods on Log and calling any method/field on Panache entities) it's now going to be possible to get "users" that "only" declare our types (Log or Panache entities) somewhere in their signatures without calling any method on them, which may be "false positives" in these cases.
In the case of Panache, we'll register a class visitor/transformer too many, but it won't do anything since it won't find any field access to transform. The chances of classes having signature references to Panache entities without using their fields is plausible.
In the case of Quarkus Log it may be that we define an extra static logger for a class that will go unused, but the chances of that happening is pretty unlikely.
|
Agree. Thanks! |
Previously, the `getKnownUsers()` method only considered a class as used in another class when it occured in the list of class references in the other class's constant pool. With this commit, a class is also considered as used in another class when it occurs in the other class's signature (superclass type, superinterface types, type parameters, permitted subclasses), in the signatures of the other class's methods (return type, parameter types, exception types, type parameters), or in the types of the other class's fields and record components.
Ladicek
force-pushed
the
improve-known-users
branch
from
84e7350
to
3a80388
Compare
See also https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/hibernate.20reactive/near/424410591