Split build process per-platform #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 30, 2024
Merged
There was a problem hiding this comment.
A quick sweep of the diff doesn't raise any flags for me. But I do have a bit of aversion to implementing our own logger system.
I haven't tested this yet. I plan on leaving that until after I run through the other PR's. I think it'd be better if I tested everything at once vs separately.
This refactoring looks good to me otherwise
smallketchup82
requested changes
Aug 30, 2024
smallketchup82
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of my biggest issues right now is that the main method is unreadable due to everything being bundled into it. I've split it out into individual
Builders andUploaders.While there are some logical changes, I've tried to avoid them as much as possible. As a result this PR makes no effort so far to fix e.g. the macOS build being broken.