Security Patch for API key in URL #895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vigation of Authorization header that casues API key to be exposed in URL.
|
Hello, thanks for catching that one :) I'll see about getting it merge upstream asap. |
MarcMcIntosh
pushed a commit
that referenced
this pull request
Sep 17, 2025
…vigation of Authorization header that casues API key to be exposed in URL. (#895)
|
cherry picked to the dev branch 51a2336 |
|
@MarcMcIntosh Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the circumnavigation by stopping the browser from automatically grabbing the form key and sticking it in the URL.
The Issue
There's a lot of really nice security practices within the web gui. However, a missing PreventDefault() function in the Login Form is causing the API key and endpoint to be leaked into the URL, adding a circumnavigation to using just the Authorization header.
The fix
The newly added PreventDefault() in the login form stops the API key from leaking into the URL, which may propagate to Browser histories and server logs with the API key attached. Here's how it looks now:
On Chrome:
On Safari:
