Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cli, --output-file option #7

Merged
merged 3 commits into from
May 24, 2023
Merged

Update cli, --output-file option #7

merged 3 commits into from
May 24, 2023

Conversation

rue-a
Copy link
Collaborator

@rue-a rue-a commented May 22, 2023

The help of the --output-file option did not align with the actual behavior.

@rue-a rue-a requested a review from bertsky May 22, 2023 14:54
bertsky
bertsky reviewed May 22, 2023
View reviewed changes
Copy link
Member

@bertsky bertsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure? That should already be covered by allow_dash=True above. Click is supposed to open sys.stdout for writing in this case.

@rue-a
Copy link
Collaborator Author

rue-a commented May 22, 2023

it did not work as I tried it.

@bertsky
Copy link
Member

bertsky commented May 22, 2023

it did not work as I tried it.

indeed. IMO the mistake was to set default='-'. Should just be None or no default key IIRC.

@rue-a rue-a merged commit 3f4ec5f into master May 24, 2023
@rue-a rue-a mentioned this pull request May 24, 2023
Closed
@rue-a rue-a deleted the update-cli branch May 25, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertsky bertsky bertsky left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rue-a @bertsky