Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Toggle metadata, toc and metadata subentries #336

Merged
merged 3 commits into from
Feb 10, 2025
Merged

[FEATURE] Toggle metadata, toc and metadata subentries #336

merged 3 commits into from
Feb 10, 2025

Conversation

markusweigelt
Copy link
Contributor

@markusweigelt markusweigelt commented Feb 6, 2025 •
edited
Loading

  • Update control icons SVG and improve css and less to handle new size of background image
  • Toggle table of contents section, metadata section and grouped metadata
  • Adjust template to show headlines of metadata and toc in sidebar

Depends on kitodo/kitodo-presentation#1478

Implementation partially based on the following PR #230

@markusweigelt markusweigelt changed the title Toggle metadata [FEATURE] Toggle metadata Feb 6, 2025
@markusweigelt markusweigelt changed the title [FEATURE] Toggle metadata [FEATURE] Toggle metadata, toc and metadata subentries Feb 6, 2025
@beatrycze-volk beatrycze-volk added the ✔️ feature A new feature or enhancement. label Feb 6, 2025
@beatrycze-volk beatrycze-volk added this to the DFG-Viewer 6.3.0 milestone Feb 6, 2025
@beatrycze-volk
Copy link
Contributor

@markusweigelt on which version of Kitodo.Presentation this changes are basing? 5.0.x or 5.1.x?

@markusweigelt
Copy link
Contributor Author

markusweigelt commented Feb 6, 2025 •
edited
Loading

@beatrycze-volk Should be based on v5.1.x. The changes to musical sources and your modifications to revert something with kitodo/kitodo-presentation@5240b16 are labeled with the versions v5.1.0-rc2 and v5.1.0-rc1.

@markusweigelt
Copy link
Contributor Author

markusweigelt commented Feb 10, 2025 •
edited
Loading

@beatrycze-volk The “depended” PR in Kitodo.Presentation is now merged into the main branch kitodo/kitodo-presentation#1478.

@beatrycze-volk
Copy link
Contributor

beatrycze-volk commented Feb 10, 2025 •
edited
Loading

@beatrycze-volk The “depended” PR in Kitodo.Presentation is now merged into the main branch kitodo/kitodo-presentation#1478.

But should be in that case this PR not going to version 7.0 which will be basing on version 6 of Kitodo? Or still it can be with 5.1?

beatrycze-volk
beatrycze-volk previously approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@beatrycze-volk beatrycze-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general all changes are looking good, it can be merged after making sure that it can depend on Kitodo.Presentation 5.1 :)

Resources/Private/Partials/ControlBar.html Outdated
<div class="control-bar-container metadata-basic">
<h3>
<span
class="sidebar-heading-label">{f:translate(key:'metadata', extensionName:'dfgviewer')}</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some reason why it is split in 2 lines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No there is no reason. I changed this to one line. Thx :)

@beatrycze-volk beatrycze-volk merged commit abc6419 into slub:master Feb 10, 2025
7 checks passed
@markusweigelt markusweigelt deleted the toggle-metadata branch February 19, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beatrycze-volk beatrycze-volk beatrycze-volk approved these changes

Assignees

@markusweigelt markusweigelt

Labels
✔️ feature A new feature or enhancement.
Projects
None yet
Milestone
DFG-Viewer 6.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@markusweigelt @beatrycze-volk