[MAINTENANCE] Update to TYPO3 12 #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related issue: #321. |
stweil
reviewed
Oct 21, 2024
markusweigelt
requested review from
beatrycze-volk
and removed request for
stweil
stweil
reviewed
Oct 22, 2024
There was a problem hiding this comment.
Thanks! I could successfully install a local DFG viewer with TYPO3 12 and load some digitized books.
|
The latest PR code with the latest Kitodo.Presentation (git master) no longer works for me (tested with TYPO3 11). Reverting the last 3 commits (d3d9181) works better, but still produces an "Oops". |
|
A fresh installation with TYPO3 12, kitodo/presentation dev-master, slub/dfgviewer dev-master + your commits, slub/slub-digitalcollections dev-master + your commits + patch for ext_emconf.php works with Oops: |
stweil
reviewed
Oct 24, 2024
stweil
reviewed
Oct 24, 2024
|
@beatrycze-volk fyi consider changes of PR slub/slub_digitalcollections#94 for testing. |
|
Could you please rebase the PR to fix the conflicts? I'd like to run a new test. |
stweil
reviewed
Nov 14, 2024
stweil
approved these changes
Nov 16, 2024
There was a problem hiding this comment.
Thank you!
The latest code now works for me with TYPO3 12. Maybe the number of commits can be reduced by squashing some (or all) of them.
There remain a few warnings in the TYPO3 log (maybe most or even all unrelated to this pull request):
Setting "displayIiifDescription" not set, using default value "1". Probably FlexForm for controller "Kitodo\Dlf\Controller\MetadataController" is not read.
Setting "displayIiifLinks" not set, using default value "1". Probably FlexForm for controller "Kitodo\Dlf\Controller\MetadataController" is not read.
Setting "displayIiifRights" not set, using default value "1". Probably FlexForm for controller "Kitodo\Dlf\Controller\MetadataController" is not read.
Setting "originalIiifMetadata" not set, using default value "0". Probably FlexForm for controller "Kitodo\Dlf\Controller\MetadataController" is not read.
Setting "pageStep" not set, using default value "5". Probably FlexForm for controller "Kitodo\Dlf\Controller\NavigationController" is not read.
Setting "storagePid" not set, using default value "0". Probably FlexForm for controller "Slub\Dfgviewer\Controller\UriController" is not read.
Setting "useInternalProxy" not set, using default value "0". Probably FlexForm for controller "Kitodo\Dlf\Controller\PageViewController" is not read.
I think that is part of the release management when the branch is merged into master. At that point, it should be squashed. Before that, it retains the possibility to revert or analyze the history.
I think it is unrelated. Maybe the log level is too sensitive in AbstractController of Kitodo.Presentation and should be adjusted to A PR for that has been created. kitodo/kitodo-presentation#1376 |
|
@markusweigelt, could you please rebase your pull request and fix the conflicts? |
|
The calendar views for newspapers seem to be broken (see #327). |
|
Please fix merge conflicts |
beatrycze-volk
requested changes
Feb 10, 2025
|
I have testes your changes and it looks very good. Tested aspects:
Thank you very much for this upgrade! :) |
beatrycze-volk
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #321