Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show provider logo again #221

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

csidirop
Copy link
Contributor

@csidirop csidirop commented Feb 7, 2023

Due to line breaks on xpaths in https://github.com/slub/dfg-viewer/blob/master/Resources/Private/Partials/PageView.html#L62 (and ongoing lines) the provider logo was not shown:

Missing: grafik -> Not missing: grafik

This PR reverts (only) the line breaks from 17bddfc to their previous state.

Signed-off-by: Christos Sidiropoulos [email protected]

Signed-off-by: Christos Sidiropoulos <[email protected]>
@csidirop
Copy link
Contributor Author

csidirop commented Feb 13, 2023

An other way to reproduce this, is to use our docker images:

  1. Clone repo: git clone https://github.com/UB-Mannheim/kitodo-presentation-docker
  2. Change dir: cd kitodo-presentation-docker
  3. Change branch: git checkout dfg-viewer-dev
  4. Start docker container: docker compose up
  5. Wait till everything is up
  6. open: localhost and use any of the examples or use your own METS file, e.g.: http://localhost/viewer?tx_dlf[id]=https%3A%2F%2Fdigi.bib.uni-mannheim.de%2Ffileadmin%2Fvl%2Fubmaosi%2F59088%2F59088.xml

@stweil
Copy link
Contributor

stweil commented Apr 22, 2023

Ping?

@csidirop
Copy link
Contributor Author

Any questions regarding this PR?

@beatrycze-volk beatrycze-volk merged commit 5d0d012 into slub:master Oct 18, 2023
@csidirop csidirop deleted the bugfix/noproviderlogo branch October 19, 2023 13:23
@csidirop csidirop mentioned this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants