-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix character overlap in toc (between caret-down and title) #212
fix character overlap in toc (between caret-down and title) #212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should css files not be rebuild?
Yes, they should be rebuilt. Maybe it would be even better to remove generated files like Resources/Public/Css/allStyles.css, Resources/Public/Css/webStyles.css, Resources/Public/Css/rte.css, Resources/Public/JavaScript/allScripts.js or Resources/Public/JavaScript/webScripts.js from git and add them to .gitignore. |
But then they would have to be created manually |
Right, developers who use code from git would be forced to build them. But the TYPO3 extension should of course include them and not require an additional build step. |
Sorry I forgot to recreate the CSS file. |
In this case you would have to document the necessary development environment, I get an error with npm install with nodejs versions > 17.3.1 for example. |
before the fix:

after the fix:

Example: https://dfg-viewer.de/show/?tx_dlf%5Bid%5D=https%3a%2f%2fdigi.bib.uni-mannheim.de%2foai%2f%3fverb%3dGetRecord%26metadataPrefix%3dmets%26identifier%3d489121969