Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show message for old browsers (IE11, Firefox 52 esr) #182

Merged
merged 3 commits into from
Apr 12, 2021
Merged

Show message for old browsers (IE11, Firefox 52 esr) #182

merged 3 commits into from
Apr 12, 2021

Conversation

albig
Copy link
Contributor

@albig albig commented Apr 11, 2021

This PR does:

  • show message about outdated browser
    • only on browsers not supporting the nomodule attribute of the script-tag (IE11, Firefox 52)
    • possibility to hide the message
  • This will close Darstellungsproblem im IE 11 #173. IE 11 won't be supported anymore!

Besides this, minor changes have been done:

@albig albig added 🐛 bug A non-security related bug. 📜 javascript Pull requests that update Javascript code labels Apr 11, 2021
@albig albig added this to the DFG-Viewer 5.2.0 milestone Apr 11, 2021
@albig albig self-assigned this Apr 11, 2021
@albig albig requested a review from ByteParty April 11, 2021 21:45
@albig albig merged commit c832c5e into master Apr 12, 2021
@albig albig deleted the fix-173 branch April 12, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ByteParty ByteParty Awaiting requested review from ByteParty

Assignees

@albig albig

Labels
🐛 bug A non-security related bug. 📜 javascript Pull requests that update Javascript code
Projects
None yet
Milestone
DFG-Viewer 5.2.0
Development

Successfully merging this pull request may close these issues.

Darstellungsproblem im IE 11
1 participant
@albig