-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add tests for v1.7.0 builders #638
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 0 additions & 4 deletions
4
cli/slsa-verifier/testdata/gha_container-based/main/workflow_dispatch.main.default
This file was deleted.
Oops, something went wrong.
1 change: 0 additions & 1 deletion
1
...verifier/testdata/gha_container-based/main/workflow_dispatch.main.default.intoto.sigstore
This file was deleted.
Oops, something went wrong.
Empty file.
1 change: 1 addition & 0 deletions
1
.../testdata/gha_container-based/v1.7.0/binary-linux-amd64-workflow_dispatch.intoto.sigstore
Large diffs are not rendered by default.
Oops, something went wrong.
Empty file.
1 change: 1 addition & 0 deletions
1
...ha_container-based/v1.7.0/gha_container-based-binary-linux-amd64-v13.0.30.intoto.sigstore
Large diffs are not rendered by default.
Oops, something went wrong.
Empty file.
Empty file.
1 change: 1 addition & 0 deletions
1
...a/gha_container-based/v1.7.0/gha_container-based-binary-linux-amd64-v14.2.intoto.sigstore
Large diffs are not rendered by default.
Oops, something went wrong.
1 change: 1 addition & 0 deletions
1
...ata/gha_container-based/v1.7.0/gha_container-based-binary-linux-amd64-v14.intoto.sigstore
Large diffs are not rendered by default.
Oops, something went wrong.
Binary file added
BIN
+2.05 MB
cli/slsa-verifier/testdata/gha_generic/v1.7.0/binary-linux-amd64-push-v13.0.30
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we just not run the test in parallel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one in particular takes a very long time since it scales across the builders and vers and makes online requests to Rekor - I'll try it out, but I think the best solution is just of get rid of the env var by regenerating the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how to specify it, but if we could run these tests (the test cases run by
t.Run
) in parallel but not concurrently with other top-level tests then it should work.