-
Notifications
You must be signed in to change notification settings - Fork 768
Fix Listview for qt style #9938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I tried to write a test as suggested in #9696, but I could not trigger the bug in the test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the follow up.
| self.saved-values.pressed-value = -root.value; | ||
| self.saved-values.maximum = root.maximum; | ||
| self.saved-values.x = self.mouse-x; | ||
| self.saved-values.y = self.mouse-y; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of one single assignment rather than 4 would be slightly more efficient:
self.saved-values = { pressed-value: -root.value, maximum: ..... }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I adjusted the first commit.
…press. This change was suggested in PR 9696
a6ab84e to
d9bbc21
Compare
|
Thank you! |
This is a follow up to PR #9696.
As suggested a struct property is used to save the reference values.
This also fixes the scrolling bug for the Qt style (Fixes #9208).