Skip to content

Conversation

@expenses
Copy link
Contributor

@expenses expenses commented Nov 3, 2025

Not implemented for cpp yet

@expenses expenses requested review from ogoffart and tronical November 3, 2025 15:53
@expenses expenses marked this pull request as ready for review November 3, 2025 16:10
Copy link
Member

@ogoffart ogoffart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can there be a test?

I believe this could be also use from the AboutSlint widget.

@expenses expenses requested a review from ogoffart November 3, 2025 17:19
@expenses expenses merged commit 8a43b39 into slint-ui:master Nov 4, 2025
41 checks passed
@expenses
Copy link
Contributor Author

expenses commented Nov 4, 2025

Can there be a test?

I believe this could be also use from the AboutSlint widget.

I looked into adding a test here: https://github.com/slint-ui/slint/compare/master...expenses:slint:open-url-test?expand=1. It's a bit tricky as open-url is SlintInternal. I'd also need to change the open_url function so that it logs something when testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants