Add a 100ms delay before forwarding the event in a Flickable #1652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was reported an annoying visual bug when flicking over a listview with item that has a special effect on pressed, that the items would show "pressed" for a brief instant. This patch add a small delay before sending the press event to the children. The FIXME in the test is not a regression. (This happens because we send Exited event to the children when flicking, despite the mouse is still in the area) Added a update_timers_and_animations from slint_mock_elapsed_time so we don't have to call update_timers_and_animations ourselves in the test anymore to fire the timers (it was previously only touching the animation property)
ogoffart
force-pushed
the
olivier/flickable
branch
from
38645bd to
10fc887
Compare
The nodejs tests don't use the testing backend, as a result, calling `platform::update_timers_and_animations` would use the real time instead of the fake time. So call `maybe_activate_timers` with the fake time instead
tronical
approved these changes
Sep 16, 2022
Member
tronical
left a comment
tronical
left a comment
There was a problem hiding this comment.
Nice! Does it still feel okay with nested flickables? I guess it’s fine when releasing (so clicking is all good).
| .apply_pin(flick) | ||
| .set_animated_value(final_pos.y, anim); | ||
| let millis = (crate::animations::current_tick() - pressed_time).as_millis(); | ||
| if dist.square_length() > (DISTANCE_THRESHOLD * DISTANCE_THRESHOLD) as f32 && millis > 1 |
Member
There was a problem hiding this comment.
Perhaps this is also worth mentioning in the changelog?
Member
Author
There was a problem hiding this comment.
This particular line is just not doing an animation if the mouse hasn't moved
| let event = match mouse_input_state.delayed.take() { | ||
| Some(e) => e.1, | ||
| None => return mouse_input_state, | ||
| }; |
Member
There was a problem hiding this comment.
This is where the timer is dropped and stopped, right?
Member
Author
There was a problem hiding this comment.
yes.
You think it sould have a comment?
Member
There was a problem hiding this comment.
No, I think it’s fine. Just wanted to make sure I understand correctly.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported an annoying visual bug when flicking over a listview with item that has a special effect on pressed, that the items would show "pressed" for a brief instant. This patch add a small delay before sending the press event to the children.
The FIXME in the test is not a regression. (This happens because we send Exited event to the children when flicking, despite the mouse is still in the area)
Added a update_timers_and_animations from slint_mock_elapsed_time so we don't have to call update_timers_and_animations ourselves in the test anymore to fire the timers (it was previously only touching the animation property)