Allow semicolon_in_expressions_from_macros lint in build scripts usin…#12505
Merged
Conversation
…g cfg_aliases Rust nightly from 2026-07-16 on turns this lint into a deny-by-default error, and the expansion of the cfg_aliases! macro trips it. This broke the rust-cpp-docs and cpp_cmake nightly CI jobs when compiling the i-slint-renderer-skia build script; the other build scripts using cfg_aliases would fail the same way once reached. Allow the lint in the affected build scripts until the upstream fix (katharostech/cfg_aliases#15) is merged and released.
…h_builtin_structs Rust nightly from 2026-07-16 on rejects macro expansions that leave a trailing semicolon in expression position (deny-by-default semicolon_in_expressions_from_macros lint). for_each_enums! is used in expression position in the interpreter's dynamic_item_tree.rs, which broke the rust-cpp-docs CI job. Expand to a brace-delimited invocation without a trailing semicolon, which is valid in both item and expression position, like for_each_keys already does. for_each_builtin_structs had the same latent pattern, so fix it as well even though all its current callers are in item or statement position.
ogoffart
approved these changes
Jul 16, 2026
tronical
enabled auto-merge (rebase)
July 16, 2026 09:20
tronical
disabled auto-merge
July 16, 2026 09:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…g cfg_aliases
Rust nightly from 2026-07-16 on turns this lint into a deny-by-default error, and the expansion of the cfg_aliases! macro trips it. This broke the rust-cpp-docs and cpp_cmake nightly CI jobs when compiling the i-slint-renderer-skia build script; the other build scripts using cfg_aliases would fail the same way once reached.
Allow the lint in the affected build scripts until the upstream fix (katharostech/cfg_aliases#15) is merged and released.