Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite Router->urlFor() to generate complete Urls #2493

Merged
merged 22 commits into from
Apr 23, 2019
Merged

Rewrite Router->urlFor() to generate complete Urls #2493

merged 22 commits into from
Apr 23, 2019

Commits on Aug 22, 2018

  1. Implement Router->urlFor()

    Carl Aischmann committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    7981dd9 View commit details
    Browse the repository at this point in the history

  2. Write test for urlFor()

    Carl Aischmann committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    ee827d0 View commit details
    Browse the repository at this point in the history

  3. Cleanup

    Carl Aischmann committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    1da8ef3 View commit details
    Browse the repository at this point in the history

  4. Test urlFor() with sub directory

    Carl Aischmann committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    1ee7afd View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2019

  1. Refactor Router:urlFor() to Router::fullUrlFor()

    Carl Aischmann committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    1b3b378 View commit details
    Browse the repository at this point in the history

  2. Restore old Router::urlFor()

    Carl Aischmann committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    a7ef49c View commit details
    Browse the repository at this point in the history

  3. Remove deprication notice in Router::urlFor()

    Carl Aischmann committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    4981c74 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2019

  1. Let Router::pathFor() call Router::urlFor()

    Carl Aischmann committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    5b08ef3 View commit details
    Browse the repository at this point in the history

  2. Merge branch '3.x' into 3.x

    @Jmp00000001
    Jmp00000001 authored Apr 9, 2019
    Configuration menu
    Copy the full SHA
    9c4750c View commit details
    Browse the repository at this point in the history

  3. Remove 'deprecated' line from Router::urlFor() docblock

    Carl Aischmann committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    b0f193c View commit details
    Browse the repository at this point in the history

  4. Adjust docblock for Router::urlFor() matchin Router::pathFor()

    Carl Aischmann committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    ed2ccab View commit details
    Browse the repository at this point in the history

  5. Add deprecation information to Router::pathFor() docblock

    Carl Aischmann committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    1dfaf7e View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2019

  1. Check if is set when generating full url

    Carl Aischmann committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    bd72ddd View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary check if is string

    Carl Aischmann committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    2fb9ad2 View commit details
    Browse the repository at this point in the history

  3. Add test for Router::fullUrlFor() when Container is not set

    Carl Aischmann committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    57e2826 View commit details
    Browse the repository at this point in the history

  4. Pass uri via function parameter

    @Jmp00000001
    Jmp00000001 committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    a877935 View commit details
    Browse the repository at this point in the history

  5. Remove obsolete test: testFullUrlForWithouthContainer()

    @Jmp00000001
    Jmp00000001 committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    43a0ed2 View commit details
    Browse the repository at this point in the history

  6. Adjust testFullUrlFor()

    @Jmp00000001
    Jmp00000001 committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    2810242 View commit details
    Browse the repository at this point in the history

  7. Use alias Slim\Http\Uri

    @Jmp00000001
    Jmp00000001 committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    c44bfae View commit details
    Browse the repository at this point in the history

  8. Remove return type declaration for Router::fullUrlFor()

    @Jmp00000001
    Jmp00000001 committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    e05f430 View commit details
    Browse the repository at this point in the history

  9. Remove type declaration in function head fullUrlFor()

    @Jmp00000001
    Jmp00000001 committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    4ff4d16 View commit details
    Browse the repository at this point in the history

  10. Add white space after comma in function call

    @Jmp00000001
    Jmp00000001 committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    e6ff493 View commit details
    Browse the repository at this point in the history