Adds the ability to specify attributes via lists #157
Conversation
|
Note that variables provided by bindings/assigns do basically work, but with some interesting caveats I found that doing template = ~S(div data-attr=attr)
Slime.render(template, attr: [1,2,3])produces a binary mostly like the one we desire, but with somewhat odd output: This appears to be because of the conversion of With strings as the values of the variable, we get a result closer to what we want, but not quite perfect: I believe this is because the variables are being directly passed through to EEx, and are thus exempt from the list manipulation code I've added. Adding code that can take and act on these is not difficult, but it does have potentially wide-reaching repercussions, as it may impact the way Phoenix and other tools pass their assigns in; so I've left it as-is. |
|
Great job, @paradox460, sorry for the delay. |
|
No problem, thank you! |
The ruby slim specification states that attributes can be provided by an array
with the expected output of
This PR introduces that feature.
Additionally, I added support for lists to the attribute merge module, so you can do the following
and get
This fixes #156