feat(export): add basic metatada to exported PDF #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
changed the title
antfu
reviewed
Nov 25, 2022
packages/slidev/node/export.ts
Outdated
| @@ -223,9 +224,18 @@ export async function exportSlides({ | |||
| preferCSSPageSize: true, | |||
| }) | |||
|
|
|||
| // Edit generated PDF: add metadata and (optionally) TOC | |||
| let pdfData = fs.readFileSync(output) | |||
There was a problem hiding this comment.
Can we use the promises version of fs? Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #669
pdf-libdependency was added and an option to process exported PDF to add some info to it.Why not go further and enhance exported PDF a little bit more, adding basic metadata to it?
Before:
After (look at window title):