Improve error reporting in github actions

slaveOftime · Oct 21, 2024 · fc9808c · fc9808c
1 parent 0953d6c
commit fc9808c
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/Fun.Build/CHANGELOG.md b/Fun.Build/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## [Unreleased]
 
+## [1.1.11] - 2024-10-21
+
+- Improve error reporting in github actions
+
 ## [1.1.10] - 2024-10-21
 
 - Improve error reporting in github actions

diff --git a/Fun.Build/PipelineContextExtensions.fs b/Fun.Build/PipelineContextExtensions.fs
@@ -59,7 +59,7 @@ module PipelineContextExtensionsInternal =
             }
 
 
-        member this.GetErrorPrefix() = if this.EnvVars.ContainsKey("GITHUB_ENV") then "::error" else "Error:"
+        member this.GetErrorPrefix() = if this.EnvVars.ContainsKey("GITHUB_ENV") then "::error::" else "Error: "
 
 
         member this.RunStages(stages: StageContext seq, cancelToken: Threading.CancellationToken, ?failfast: bool) =
@@ -158,7 +158,7 @@ module PipelineContextExtensionsInternal =
             if pipelineExns.Count > 0 then
                 for exn in pipelineExns do
                     let innerMessage = if exn.InnerException <> null then exn.InnerException.Message else ""
-                    AnsiConsole.MarkupLineInterpolated $"[red]{this.GetErrorPrefix()} {exn.Message} {innerMessage}[/]"
+                    AnsiConsole.MarkupLineInterpolated $"[red]{this.GetErrorPrefix()}{exn.Message} {innerMessage}[/]"
                 AnsiConsole.WriteLine()
                 raise (PipelineFailedException("Pipeline is failed because of exception", pipelineExns[0]))
             else if hasError then

diff --git a/Fun.Build/StageContextExtensions.fs b/Fun.Build/StageContextExtensions.fs
@@ -64,8 +64,8 @@ module StageContextExtensionsInternal =
 
         member ctx.GetErrorPrefix() =
             match ctx.TryGetEnvVar("GITHUB_ENV") with
-            | ValueSome _ -> "::error"
-            | _ -> "Error:"
+            | ValueSome _ -> "::error::"
+            | _ -> "Error: "
 
 
         member ctx.GetNoPrefixForStep() =
@@ -253,9 +253,9 @@ module StageContextExtensionsInternal =
                                         | Error e ->
                                             if String.IsNullOrEmpty e |> not then
                                                 if not isParallel && stage.GetNoPrefixForStep() then
-                                                    AnsiConsole.MarkupLineInterpolated $"""[red]{stage.GetErrorPrefix()} {e}[/]"""
+                                                    AnsiConsole.MarkupLineInterpolated $"""[red]{stage.GetErrorPrefix()}{e}[/]"""
                                                 else
-                                                    AnsiConsole.MarkupLineInterpolated $"""[red]{stage.GetErrorPrefix()} {prefix} {e}[/]"""
+                                                    AnsiConsole.MarkupLineInterpolated $"""[red]{stage.GetErrorPrefix()}{prefix} {e}[/]"""
                                             return false
                                         | Ok _ -> return true
                                       }