Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix integration tests action #364

Merged
merged 6 commits into from
Jan 16, 2024
Merged

fix: Fix integration tests action #364

merged 6 commits into from
Jan 16, 2024

Commits on Jan 16, 2024

  1. Return exit code 3 when scans fail 

    This way we can differentiate between scans failing because
of flagged issues versus failing for other reasons.
This will be useful for having better tests in our pipeline.
    @tdurk93
    tdurk93 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    5b41c24 View commit details
    Browse the repository at this point in the history

  2. Fix code comment

    @tdurk93
    tdurk93 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    f26c305 View commit details
    Browse the repository at this point in the history

  3. Force pipeline powershell script to return success 

    Because scans return a nonzero exit code then they flag an issue,
the smoke test script to run a scan was causing the pipeline build to fail.
    @tdurk93
    tdurk93 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    82f6e3f View commit details
    Browse the repository at this point in the history

  4. Force MacOS smoke test to run with python 3.11 

    And include commented-out code to enable python 3.12 support.
The python package dependency-injector doesn't yet support python 3.12.
There is a PR for enabling that support that is not yet merged.
I've opted to leave that commented-out because it will cause the
build to break once the PR branch it points to gets merged/deleted.
    @tdurk93
    tdurk93 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    02925a4 View commit details
    Browse the repository at this point in the history

  5. Leave comment in integration_testing.yml GH action

    @tdurk93
    tdurk93 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    dfe5b85 View commit details
    Browse the repository at this point in the history

  6. Rename GH Actions workflow jobs 

    Renaming "osx" to "macos"
    @tdurk93
    tdurk93 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    7e83c32 View commit details
    Browse the repository at this point in the history