Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature oauth v2 authorization code #14

Closed
wants to merge 2 commits into from
Closed

Feature oauth v2 authorization code #14

wants to merge 2 commits into from

Conversation

wize-wiz
Copy link

Solves #12

@wize-wiz
Implement the usage of grand_type=authorization_code instead of the d…
3b8fa47 
…eprecated and removed feature for new OAuth clients, called `grand_type=password`. Update README to reflect this change. Added two commands for ease of use.
@wize-wiz
Replace deprecated array_where with Arr::where version.
775dbc0
valeksa
valeksa reviewed Nov 5, 2020
View reviewed changes
Copy link

@valeksa valeksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commands\GoToAuthorizeLinkCommand.php file is missing?

@wize-wiz
Copy link
Author

wize-wiz commented Nov 5, 2020 •
edited
Loading

@valeksa Aah that line can be removed, GoToGenerateLinkCommand used to be called GoToAuthorizeLinkCommand. I have mostly rewritten this entire package in a new repository anyway, this PR is quite thin compared of what it can do now.

@valeksa
Copy link

valeksa commented Nov 6, 2020

Hello,

I just want to say that I have tested on two clients and this PR works without problem,
with GOTO_LEGACY=true (old client Direct Login) and new client.

But according to README, to generate an authorization link we have to execute following command:
php artisan goto:authorize-link

but this command does not exist, so we have to generate authorization link by hand according to gotowebinar documentation.

On more thing, version of PHP should be 7.4. On 7.2 php artisan command can not be executed.

@wize-wiz
Copy link
Author

@valeksa Which command can't be executed on 7.2?

@wize-wiz wize-wiz closed this by deleting the head repository Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valeksa valeksa valeksa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wize-wiz @valeksa