FIX: Disconnect the value signal when removing a listener from a connection #1208
+139
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a listener is removed from a connection
…s from the base plugin works as expected
| @@ -214,6 +217,25 @@ def remove_listener(self, channel, destroying: Optional[bool] = False) -> None: | |||
| except (KeyError, TypeError): | |||
| pass | |||
|
|
|||
| if channel.value_signal is not None and hasattr(self, "put_value"): | |||
There was a problem hiding this comment.
if we can't guarantee the value_signal exists for all the types we call in 'value_signal[<type>]', i think we need catch KeyError here? (and could catch IndexError too for pyside6 support, since has diff internal structure for it)
also if u want, can be made into a shorter equivalent for-loop. i recently changed some other similar instances to a loop here: https://github.com/slaclab/pydm/pull/1197/files#diff-122f4c6562ac7f62ec92c020c468fc0994e5b4de3170b2556ce1249d892f316aR207
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Addresses #1186.
When calling set_channel on a PyDMWidget, the process is:
PyDMConnectionassociated with the addressPyDMConnectionfor that address entirelyThe problem in #1186 seems to be that the
value_signalis not disconnected, so if there is still an active listener such that the connection is not closed out entirely, that signal remains active and will continue to send even though the channel should have been replaced.This should fix it by ensuring the
value_signalis disconnected as part ofremove_listeneralong with all the other signals.Testing
Made a display that reproduced #1186. Manually verified that the problem went away after this PR. Added new unit tests, including one that does fail prior to this PR and passes now.