MNT: switch from python2 style super() calls to python3 #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstelter-slac
force-pushed
the
use_python3_super_calls
branch
from
5b3d13e to
1041426
Compare
The background on this patch is that running on pyside6 exposes some weirdness which how we are doing super() __init__ calls, so this it comes as some cleanup before another fix that will follow. python2 style: super(ClassName, self).__init__() python3 style: super().__init__() While these python2 style calls work on python3, the new way is cleaner and imo it's best to follow python3's conventions as we officially don't support python2. references: https://docs.python.org/3/library/functions.html#super https://stackoverflow.com/a/19776143
nstelter-slac
force-pushed
the
use_python3_super_calls
branch
from
1041426 to
b9338a5
Compare
nstelter-slac
changed the title
nstelter-slac
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The background on this patch is that running on pyside6 exposes some weirdness which how we are doing super() __init__ calls, so this it comes as some cleanup before another fix that will follow.
these calls are equivalent (in python3):
python2 style:
super(ClassName, self).__init__()python3 style:
super().__init__()While these python2 style calls work on python3, the new way is cleaner and imo it's best to follow python3's conventions as we officially don't support python2.
references:
https://docs.python.org/3/library/functions.html#super
https://stackoverflow.com/a/19776143