MNT: appease newer python by not using enum to index into tuple #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstelter-slac
changed the title
Seems like the newer python im running pyside6 on doesn't like using enums to index into a tuple: "TypeError: tuple indices must be integers or slices, not LayoutType" so use a map for 'layout_class_for_type' instead. (using the enum's '.value' should allow for indexing into the tuple too, but imo using the map is more readable.)
nstelter-slac
force-pushed
the
fix_temp_repeater
branch
from
71a48ac to
9b4d2fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like the newer python im running pyside6 on doesn't like using enums to index into a tuple: "TypeError: tuple indices must be integers or slices, not LayoutType"
so use a map for 'layout_class_for_type' instead. (using the enum's '.value' should allow for indexing into the tuple too, but imo using the map is more readable.)
this works fine still older python