MNT: pyside6 just throws an IndexError instead when connecting to value_signals not overloaded with the specified type #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue_signals not overloaded with the specified type pyqt5: missing overload = KeyError pyside6: missing overload = IndexError
nstelter-slac
force-pushed
the
plugin_fix
branch
from
182991f to
09838c0
Compare
equivalent for-loop and catch TypeErrors too] Also add comments to explain why we are catching these specific errors.
nstelter-slac
requested review from
YektaY and
jbellister-slac
and removed request for
YektaY
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyqt5: missing overload = KeyError
pyside6: missing overload = IndexError
also make plugin channel connecting/disconnecting into a nicer equivalent for-loop, and add catching TypeErrors too (explanation in new comments)
and add comments to explain why we are catching these specific errors.