MNT: update enum-button widget's button-group to use proper clicked signal, avoid pyside6 error #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstelter-slac
force-pushed
the
enum_button_fix
branch
from
e2015a1 to
b6d7a8b
Compare
signal, avoid pyside6 error Calling signal without overloaded int and expecting a button object back, is whats specified in qt5 docs: https://doc.qt.io/qt-5/qbuttongroup.html#buttonClicked. This is the same in the qt6 docs, and pyside6 even throws error if signal is not used in this correct way. Also seems like the newer python in running pyside6 on doesn't like using enums to index into an array, so use a map for 'class_for_type' instead. (using the enum's '.value' should allow for indexing into an array, but imo using the map is more readable.)
nstelter-slac
force-pushed
the
enum_button_fix
branch
from
b6d7a8b to
8692048
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling signal without overloaded int and expecting a button object back, is whats specified in qt5 docs:
https://doc.qt.io/qt-5/qbuttongroup.html#buttonClicked.
This is the same in the qt6 docs, and pyside6 even throws error if signal is not used in this correct way.
Also i think its the newer python im running with pyside6 that doesn't like using enums to index into an array, so use a map for 'class_for_type' instead.
(using the enum's '.value' should also allow for indexing into an array, but imo using the map is more readable.)