ENH: Adds Labels to Timeplot Crosshair #1173
Conversation
YektaY
changed the title
Added in displying channel severity on the crosshair labels. Added unit tests.
Oh that is a good point, I was mainly focused on it working for the archive viewer. I would be happy to move it into baseplot |
| @@ -115,6 +116,9 @@ def __init__(self, channel_address=None, plot_by_timestamps=True, plot_style="Li | |||
| self.channel = None | |||
| self.units = "" | |||
|
|
|||
| self.severity_raw = -1 | |||
| self.severity = "N/A" | |||
There was a problem hiding this comment.
minor optional change,
but we could add the following constants to this file (but not as members of class):
DEFAULT_SEVERITY_RAW = -1
DEFAULT_SEVERITY_STRING = "N/A"
and then import into tests, similar to "MINIMUM_BUFFER_SIZE",
and use for the testing comparisons
could also do this with "No data!" string too.
makes it easier to manage these hard coded values.
| ------- | ||
| None | ||
| """ | ||
| if not np.isfinite(x_val): |
There was a problem hiding this comment.
do we want to be setting "No data!" here?
"If x_val is not finite ... the label text is set to "No data!"
|
also nice patch! |
Description
Creates labels on the vertical crosshair at the intersection point of the curves. This PR also addresses some bugs in crosshair functionality
Motivation and Context
Screenshots