Enable new LSP tracing capability #29
Conversation
package.json
Outdated
| @@ -235,7 +246,7 @@ | |||
| ] | |||
| }, | |||
| "activationEvents": [ | |||
| "workspaceContains:.hhconfig" | |||
There was a problem hiding this comment.
All Hack workspaces need to have a .hhconfig file at root, so this is a good indicator for activating the extension. This way functionality like typechecking and linting can start in the background without needing to open any file.
There was a problem hiding this comment.
Gotcha. The key thing from a VS Code perspective is perf. We commend only starting the LSP when it's strictly needed, so you might reconsider to have multiple activation contexts.
| @@ -224,6 +224,17 @@ | |||
| }, | |||
| "default": {}, | |||
| "description": "Workspaces where whether or not to run custom Hack executables (e.g. hhast-lint) has been remembered" | |||
| }, | |||
| "hack.trace.server": { | |||
There was a problem hiding this comment.
Is this config read by vscode automatically? (I don't see it used anywhere)
There was a problem hiding this comment.
This is an implicit feature of the languageclient. See https://github.com/Microsoft/vscode-languageserver-node/blob/master/client/src/client.ts#L2872
This reverts commit 32a548d.
|
Activation changed reverted. |
This PR enables our new LSP tracing capability, which creates an output channel in VS Code that allows easy inspection of the LSP traffic, which can be analyzed with https://microsoft.github.io/language-server-protocol/inspector/.
See microsoft/language-server-protocol-inspector#8 + octref/lsp-inspector#8
Changes
new hack.tracing.serveroptionhackas it's use as the namespace for the trace setting