slack-vitess-r14.0.5-dsdefense: txthrottler: further code cleanup (#12902)#97
Merged
timvaillancourt merged 1 commit intoslack-vitess-r14.0.5-dsdefensefrom Jul 3, 2023
Conversation
* txthrottler: further code cleanup Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix bad merge resolution Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
ejortegau
reviewed
Jun 29, 2023
ejortegau
left a comment
ejortegau
left a comment
There was a problem hiding this comment.
LGTM, though some tests failed. I set them to run again.
ejortegau
approved these changes
Jul 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport vitessio#12902. Some (but not all) of this PR was already backported by a previous upstream PR that was "ahead" of this one - I'm guessing some of the changes were missed in cherry-pick conflict resolution
Related Issue(s)
vitessio#12902
Checklist
Deployment Notes