slack-vitess-r14.0.5:Implement the Vitess Structure Logger VTSLogger#80
Merged
tanjinx merged 4 commits intoslack-vitess-r14.0.5from May 11, 2023
Merged
Conversation
Signed-off-by: Emad Habib <ehabib@slack-corp.com>
tanjinx
changed the title
slack-vitess-r14.0.5:Implement the Vitess Structure Logger VTSLoger
Author
|
The tests are failing because I'm using Zap package that needs |
EmadMokhtar
force-pushed
the
emad-structured-logging-zap
branch
from
7b8b85b to
e9b19cf
Compare
Author
|
Downgrade fixed the issue. |
EmadMokhtar
changed the title
slack-vitess-r14.0.5:Implement the Vitess Structure Logger VTSLogerslack-vitess-r14.0.5:Implement the Vitess Structure Logger VTSLogger
Signed-off-by: Emad Habib <ehabib@slack-corp.com>
EmadMokhtar
force-pushed
the
emad-structured-logging-zap
branch
from
e9b19cf to
eab91bd
Compare
Signed-off-by: Emad Habib <ehabib@slack-corp.com>
Signed-off-by: Emad Habib <ehabib@slack-corp.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduce a new flag
--structured-loggingto enable usage of Zap log instead ofglog. Technically, I usenoglogpackage to bind Zap log APIs withglogAPIs. So the code can still useglogAPIs but it's Zap logger.Upstream WIP PR: vitessio#13061
Related Issue(s)
Checklist
Deployment Notes